Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ru: Make sure localized links are used rather than /en-US/* (part 1) #14263

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR fixes all of the links within the Russian locale so that they no longer point to English content. This is part 1 of 4.

@queengooborg queengooborg requested a review from a team as a code owner July 15, 2023 14:36
@queengooborg queengooborg requested review from lex111 and removed request for a team July 15, 2023 14:36
@github-actions github-actions bot added the l10n-ru Issues related to Russian content. label Jul 15, 2023
@sashasushko
Copy link
Member

@queengooborg thanks a lot for helping. There are strange build errors with EmbedLiveSample. Do you have any idea why them appear? Because I don't see changes in those parts of code.

@queengooborg
Copy link
Collaborator Author

Thanks for asking! While we do not modify the macros, we do modify the files that contain them. Since the CI test runs on all the modified files, we are notified that there are issues in the files even if the PR itself is not the source of said issues.

While we should address these issues at some point, I'd say that they are safe to ignore in this PR!

@sashasushko sashasushko merged commit e9c14aa into main Jul 17, 2023
6 of 7 checks passed
@sashasushko sashasushko deleted the ru/localized-links/1 branch July 17, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ru Issues related to Russian content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants