Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Format /learn using Prettier #14390

Merged
merged 2 commits into from
Jul 22, 2023
Merged

ja: Format /learn using Prettier #14390

merged 2 commits into from
Jul 22, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR formats the /learn folder of the Japanese locale using Prettier.

@queengooborg queengooborg requested a review from a team as a code owner July 18, 2023 17:52
@queengooborg queengooborg requested review from mfuji09 and removed request for a team July 18, 2023 17:52
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. system Infrastructure and configuration for the project labels Jul 18, 2023
@mfuji09
Copy link
Collaborator

mfuji09 commented Jul 20, 2023

@queengooborg Can you resolve the CI's error?

@queengooborg
Copy link
Collaborator Author

Hey @mfuji09! I responded to a similar request in #14263 (comment):

Thanks for asking! While we do not modify the macros [in this PR], we do modify the files that contain them. Since the CI test runs on all the modified files, we are notified that there are issues in the files even if the PR itself is not the source of said issues.

While we should address these issues at some point, I'd say that they are safe to ignore in this PR!

I do plan to resolve the CI failure in another PR (unless someone beats me to it)! For now, though, I'm focusing on the formatting, particularly as it will greatly help with fixing up other issues like broken macros and issues like what the CI reports!

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 22, 2023
@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 22, 2023
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@mfuji09 mfuji09 merged commit 338f0a9 into main Jul 22, 2023
7 of 8 checks passed
@mfuji09 mfuji09 deleted the ja/prettier/learn branch July 22, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content. system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants