Add aria-label to buttons in Sidebar #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First iteration: set the aria-label where also data-tip is used, using the same text. * Set the aria-label on the three default buttons in the bottom of the sidebar * Set the aria-label on the TabItem component for the services. Todo: * Think about better texts to aid the user instead of just re-using the labels
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration: set the aria-label where also data-tip is used, using
the same text.
sidebar
Todo:
labels
Motivation and Context
Based on the slack notification in #general @lanie Molinar, first try improve WIA-ARIA compliance
How Has This Been Tested?
Not yet... Was not succesfull to run Franz in dev mode on Windows.