Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label to buttons in Sidebar #420

Closed
wants to merge 3 commits into from
Closed

Add aria-label to buttons in Sidebar #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d071521
Add aria-label to buttons in Sidebar
Dec 2, 2017
7a9404d
Merge branch 'develop' into feature/wia-accessibility
Dec 7, 2017
c3eb96b
Merge remote-tracking branch 'stefan/develop' into feature/wia-access…
mroeling Dec 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/layout/Sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,23 @@ export default class Sidebar extends Component {
onClick={toggleMuteApp}
className={`sidebar__button sidebar__button--audio ${isAppMuted ? 'is-muted' : ''}`}
data-tip={`${intl.formatMessage(isAppMuted ? messages.unmute : messages.mute)} (${ctrlKey}+Shift+M)`}
aria-label={`${intl.formatMessage(isAppMuted ? messages.unmute : messages.mute)} (${ctrlKey}+Shift+M)`}
>
<i className={`mdi mdi-bell${isAppMuted ? '-off' : ''}`} />
</button>
<button
onClick={() => openSettings({ path: 'recipes' })}
className="sidebar__button sidebar__button--new-service"
data-tip={`${intl.formatMessage(messages.addNewService)} (${ctrlKey}+N)`}
aria-label={`${intl.formatMessage(messages.addNewService)} (${ctrlKey}+N)`}
>
<i className="mdi mdi-plus-box" />
</button>
<button
onClick={() => openSettings({ path: 'app' })}
className="sidebar__button sidebar__button--settings"
data-tip={`${intl.formatMessage(messages.settings)} (${ctrlKey}+,)`}
aria-label={`${intl.formatMessage(messages.settings)} (${ctrlKey}+,)`}
>
<i className="mdi mdi-settings" />
</button>
Expand Down
1 change: 1 addition & 0 deletions src/components/services/tabs/TabItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class TabItem extends Component {
onClick={clickHandler}
onContextMenu={() => menu.popup(remote.getCurrentWindow())}
data-tip={`${service.name} ${shortcutIndex <= 9 ? `(${ctrlKey}+${shortcutIndex})` : ''}`}
aria-label={`${service.name} ${shortcutIndex <= 9 ? `(${ctrlKey}+${shortcutIndex})` : ''}`}
>
<img
src={service.icon}
Expand Down