-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce separate ARG for extra packages list #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 24, 2020
elfosardo
force-pushed
the
install-extra-pkgs
branch
2 times, most recently
from
November 24, 2020 11:50
1b2e88f
to
5e0c7bb
Compare
/test-integration |
elfosardo
force-pushed
the
install-extra-pkgs
branch
from
November 24, 2020 13:55
5e0c7bb
to
c8a2a7e
Compare
bfournie
approved these changes
Nov 24, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 24, 2020
/retest |
1 similar comment
/retest |
Convert the current PKGS_LIST to ENV as we should not really touch it. Introduce the EXTRA_PKGS_LIST ARG to allow specifying a file containing a list of extra packages to install. The goal is to allow installing packages from different sources to test them.
elfosardo
force-pushed
the
install-extra-pkgs
branch
from
December 3, 2020 09:49
c8a2a7e
to
a411a5a
Compare
/test-integration |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Nov 2, 2021
Install newer version of oslo-messaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the current PKGS_LIST to ENV as we should not really touch it.
Introduce the EXTRA_PKGS_LIST ARG to allow specifying a file
containing a list of extra packages to install.
The goal is to allow installing packages from different sources
to test them.