Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to install extra packages in the images #1142

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Add a way to install extra packages in the images #1142

merged 1 commit into from
Mar 17, 2021

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Nov 6, 2020 •
edited
Loading

Long due change to provide a way to automatically install extra
packages in the local custom built images.
This can be useful to test different versions of packages or just
test new dependencies or tools.

This depends on metal3-io/ironic-inspector-image#72 and metal3-io/ironic-image#227

@elfosardo
Copy link
Member Author

/retest

@hardys hardys changed the title Add a way to install extra packages in the imges Add a way to install extra packages in the images Nov 9, 2020
@elfosardo
Copy link
Member Author

/retest

andfasano
andfasano reviewed Nov 12, 2020
View reviewed changes
04_setup_ironic.sh Outdated Show resolved Hide resolved
@elfosardo elfosardo marked this pull request as draft November 17, 2020 13:18
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2020
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 20, 2020 •
edited
Loading

@elfosardo: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack bf994ea link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ocp-sdn-ipv4-upgrade 869bf00 link /test e2e-metal-ipi-ocp-sdn-ipv4-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Member Author

this depends now on metal3-io/ironic-image#227 metal3-io/ironic-inspector-image#72
will update logic accordingly

@elfosardo elfosardo force-pushed the add-extra-packages branch 2 times, most recently from 7948514 to 43eeb1c Compare December 3, 2020 08:31
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@elfosardo elfosardo marked this pull request as ready for review December 3, 2020 08:32
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2020
@elfosardo elfosardo force-pushed the add-extra-packages branch 3 times, most recently from 2ba99dd to 1350689 Compare December 9, 2020 16:35
@elfosardo
Copy link
Member Author

@stbenjam @andfasano hi! Can you please give another look at this? Thanks!

andfasano
andfasano approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@andfasano andfasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine to me. Leaving to @stbenjam final review

derekhiggins
derekhiggins requested changes Jan 22, 2021
View reviewed changes
04_setup_ironic.sh Show resolved Hide resolved
@elfosardo elfosardo force-pushed the add-extra-packages branch 2 times, most recently from 177b54c to 28be002 Compare January 26, 2021 10:00
@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2021
@elfosardo
Copy link
Member Author

/retest

hardys
hardys reviewed Feb 12, 2021
View reviewed changes
config_example.sh Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2021
@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2021
@elfosardo
Copy link
Member Author

/assign @hardys @stbenjam

@elfosardo
Add a way to install extra packages in the imges
9ff44f3 
Long due change to provide a way to automatically install extra
packages in the local custom built images.
This can be useful to test different versions of packages or just
test new dependencies or tools.
Also adding a visual separation to some build logic parts.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@elfosardo
Copy link
Member Author

@derekhiggins @stbenjam @hardys any chance you can have another look at this please? Thanks!

@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@elfosardo
Copy link
Member Author

@stbenjam @hardys looking for approval :)

dtantsur
dtantsur reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@elfosardo
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-merge-robot openshift-merge-robot merged commit e6779bc into openshift-metal3:master Mar 17, 2021
@hardys hardys mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@stbenjam stbenjam Awaiting requested review from stbenjam

@andfasano andfasano Awaiting requested review from andfasano

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@hardys hardys Awaiting requested review from hardys

Assignees

@stbenjam stbenjam

@derekhiggins derekhiggins

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@elfosardo @openshift-merge-robot @derekhiggins @openshift-ci-robot @dtantsur @hardys @andfasano @stbenjam