-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support iLO4 and iLO5 BMCs #244
Conversation
/cc @dtantsur |
Getting an error in the conductor with this branch:
I believe this is happening when the |
I've proposed a fix for the KeyError: https://review.opendev.org/c/openstack/ironic/+/780270. Meanwhile, |
/test-integration |
1 similar comment
/test-integration |
config/ironic.conf.j2
Outdated
enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc | ||
enabled_boot_interfaces = pxe,ipxe,fake,redfish-virtual-media,idrac-redfish-virtual-media | ||
enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc,ilo | ||
enabled_boot_interfaces = ipxe,ilo-ipxe,pxe,ilo-pxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-virtual-media,ilo-uefi-https |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add ilo-uefi-https
, we have no code to support it in BMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed ilo-uefi-https
.
This change adds configuration for the iLO driver as per https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html The hardware interfaces for ilo are added to ironic.conf.j2 and the python3-proliantutils dependency has also been added.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, macaptain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ouch, sorry, this needs rebasing because of another change (a mere file rename). |
f005726
to
9af7066
Compare
/test-integration |
enabled_power_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc | ||
enabled_raid_interfaces = no-raid,irmc,agent,fake,ibmc,idrac-wsman | ||
enabled_hardware_types = ipmi,idrac,irmc,fake-hardware,redfish,ibmc,manual-management,ilo,ilo5 | ||
enabled_inspect_interfaces = inspector,idrac,irmc,fake,redfish,ilo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled_inspect_interfaces and enabled_power_interfaces do not support ilo5 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the look of it, there is no 'ilo5' inspect or power interface, and instead the ilo5 hardware type supports 'ilo' for these interfaces by inheritance.
This is also mentioned in the Ironic documentation on this page: https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html
The ilo5 hardware type supports all the ilo interfaces [...] except for boot and raid interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrent. iLO5 is a subclass of iLO.
/lgtm |
…-20211210 Merge metal3io master 20211210
This change adds configuration for the iLO driver as per https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html. Also see #243.
The hardware interfaces for ilo are added to ironic.conf.j2. The python3-proliantutils dependency has also been added.
I'm currently testing this image with iLO 4.