Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iLO4 and iLO5 BMCs #244

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Support iLO4 and iLO5 BMCs #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions config/ironic.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
[DEFAULT]
auth_strategy = noauth
debug = true
default_boot_interface = ipxe
dtantsur marked this conversation as resolved.
Show resolved Hide resolved
default_deploy_interface = direct
default_inspect_interface = inspector
default_network_interface = noop
enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc
enabled_boot_interfaces = pxe,ipxe,fake,redfish-virtual-media,idrac-redfish-virtual-media
enabled_bios_interfaces = idrac-wsman,no-bios,redfish,idrac-redfish,irmc,ilo
enabled_boot_interfaces = ipxe,ilo-ipxe,pxe,ilo-pxe,fake,redfish-virtual-media,idrac-redfish-virtual-media,ilo-virtual-media
enabled_deploy_interfaces = direct,fake,ramdisk
# NOTE(dtantsur): when changing this, make sure to update the driver
# dependencies in Dockerfile.
enabled_hardware_types = ipmi,idrac,irmc,fake-hardware,redfish,ibmc,manual-management
enabled_inspect_interfaces = inspector,idrac,irmc,fake,redfish
enabled_management_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc,noop
enabled_power_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc
enabled_raid_interfaces = no-raid,irmc,agent,fake,ibmc,idrac-wsman
enabled_hardware_types = ipmi,idrac,irmc,fake-hardware,redfish,ibmc,manual-management,ilo,ilo5
enabled_inspect_interfaces = inspector,idrac,irmc,fake,redfish,ilo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabled_inspect_interfaces and enabled_power_interfaces do not support ilo5 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the look of it, there is no 'ilo5' inspect or power interface, and instead the ilo5 hardware type supports 'ilo' for these interfaces by inheritance.

https://github.com/openstack/ironic/blob/8604f84fd7bda4e30d3f07005c4901f3662303a7/ironic/drivers/ilo.py#L74

This is also mentioned in the Ironic documentation on this page: https://docs.openstack.org/ironic/latest/admin/drivers/ilo.html

The ilo5 hardware type supports all the ilo interfaces [...] except for boot and raid interfaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrent. iLO5 is a subclass of iLO.

enabled_management_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc,ilo,ilo5,noop
enabled_power_interfaces = ipmitool,idrac,irmc,fake,redfish,idrac-redfish,ibmc,ilo
enabled_raid_interfaces = no-raid,irmc,agent,fake,ibmc,idrac-wsman,ilo5
enabled_vendor_interfaces = ipmitool,no-vendor,idrac,fake,ibmc
rpc_transport = json-rpc
use_stderr = true
Expand Down
1 change: 1 addition & 0 deletions ironic-packages-list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ python3-gunicorn
python3-ibmcclient
python3-ironic-prometheus-exporter
python3-jinja2
python3-proliantutils
python3-scciclient
python3-sushy
python3-sushy-oem-idrac
Expand Down