Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to set boot iso source #261

Merged
merged 1 commit into from
May 17, 2021

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented May 5, 2021

The new ramdisk_image_download_source allows to set where the boot iso
image will be served from.

Related to the ironic change https://review.opendev.org/c/openstack/ironic/+/788734

@elfosardo elfosardo marked this pull request as draft May 5, 2021 10:20
@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2021
@elfosardo elfosardo changed the title Add parameter to set ramdisk source Add parameter to set boot iso source May 5, 2021
The new ramdisk_image_download_source allows to set where the boot iso
image will be served from.
@elfosardo
Copy link
Member Author

/unhold

@elfosardo elfosardo marked this pull request as ready for review May 6, 2021 12:40
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2021
@elfosardo
Copy link
Member Author

/test-integration

@elfosardo
Copy link
Member Author

/assign @dtantsur @iurygregory

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@dtantsur
Copy link
Member

/lgtm

Taking Iury's approval as LGTM in this context.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@metal3-io-bot metal3-io-bot merged commit d9f5c46 into metal3-io:master May 17, 2021
elfosardo added a commit to elfosardo/ironic-image that referenced this pull request Mar 31, 2022
Correct version for sushy-oem-idrac for OCP 4.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants