Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1953979: Add parameter to set boot iso source #164

Merged

Conversation

elfosardo
Copy link

@elfosardo elfosardo commented May 6, 2021

The new ramdisk_image_download_source allows to set where the boot iso
image will be served from.
The new ramdisk_image_download_source allows to set where the boot iso
image will be served from.
Also set ironic version to the change where the option was added [0].

[0] https://opendev.org/openstack/ironic/commit/659eef72ee59fdeb639577c8499406f59644a433

Metal3 change metal3-io#261

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 6, 2021
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Bugzilla bug 1953979, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 1953979: Add parameter to set boot iso source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The new ramdisk_image_download_source allows to set where the boot iso
image will be served from.
Also set ironic version to the change where the option was added [0].

[0] https://opendev.org/openstack/ironic/commit/659eef72ee59fdeb639577c8499406f59644a433
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@openshift-ci-robot
Copy link

@elfosardo: This pull request references Bugzilla bug 1953979, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 1953979: Add parameter to set boot iso source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

prevalidation jobs passed, tagging in production

@iurygregory
Copy link

yay!

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo
Copy link
Author

/test e2e-metal-ipi-virtualmedia

1 similar comment
@elfosardo
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@iurygregory
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 92f2949 into openshift:master May 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

@elfosardo: All pull requests linked via external trackers have merged:

Bugzilla bug 1953979 has been moved to the MODIFIED state.

In response to this:

Bug 1953979: Add parameter to set boot iso source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants