Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable irmc bios interface #286

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Enable irmc bios interface #286

merged 1 commit into from
Jul 28, 2021

Conversation

zouy414
Copy link
Member

@zouy414 zouy414 commented Jul 13, 2021

Signed-off-by: Zou Yu zouy.fnst@cn.fujitsu.com

We are currently modifying python-scciclient to avoid the master restart due to obtaining BIOS settings during IPI installation.

After the modification is complete, we can re-enable irmc BIOS interface.

@zouy414
Enable irmc bios interface
1cf1b0d 
Signed-off-by: Zou Yu <zouy.fnst@cn.fujitsu.com>
@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2021
@hs0210 hs0210 mentioned this pull request Jul 13, 2021
Merged
@rhjanders
Copy link
Member

@Hellcatlk what's the likely timeframe of python-scciclient changes merging?

@zouy414
Copy link
Member Author

zouy414 commented Jul 16, 2021

@Hellcatlk what's the likely timeframe of python-scciclient changes merging?

Sorry, I can't give an accurate time at the moment, because during the test we found a new problem that needs to be solved.

@zouy414 zouy414 changed the title WIP: Enable irmc bios interface Enable irmc bios interface Jul 20, 2021
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
@zouy414
Copy link
Member Author

zouy414 commented Jul 20, 2021

@rhjanders The changes of scciclient has been merged.

@rhjanders
Copy link
Member

@Hellcatlk https://review.opendev.org/c/x/python-scciclient/+/801431 is the relevant change, correct?

@hase1128
Copy link

@rhjanders
correct.

@elfosardo
Copy link
Member

@Hellcatlk @hase1128 does python-scciclient 0.10.0 (latest release) include the change ?

@hase1128
Copy link

hase1128 commented Jul 20, 2021 •
edited
Loading

@elfosardo
yes, 0.10.0 is the latest release and include the necessary change.

@elfosardo
Copy link
Member

/hold we need to verify that the scciclient pkg version installed is 0.10.0 before merging this

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@elfosardo
Copy link
Member

/test-integration

@elfosardo
Copy link
Member

/approved

@elfosardo
Copy link
Member

current version installed of python-scciclient is still too old 0.9.1-0.20210512101916.82b8e6d.el8

@elfosardo
Copy link
Member

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2021
@elfosardo
Copy link
Member

/test-integration

@elfosardo
Copy link
Member

the version should now be correct, relaunched integration test to verify that we have the package python3-scciclient-0.9.1-0.20210720092752.34ccd96.el8.noarch.rpm installed

@elfosardo
Copy link
Member

we need #288

@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

/test-integration

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@elfosardo
Copy link
Member

correct version is now installed

@dtantsur
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@metal3-io-bot metal3-io-bot merged commit 9db466f into metal3-io:master Jul 28, 2021
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Aug 8, 2022
@openshift-ci
Merge pull request metal3-io#286 from dtantsur/ironic-proxy
4860848 
METAL-256: Add a new entry point for the Ironic proxy
@zouy414 zouy414 deleted the master branch May 18, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zouy414 @rhjanders @hase1128 @elfosardo @metal3-io-bot @dtantsur