Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tripleo_repos location #288

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Conversation

adetalhouet
Copy link
Contributor

The upstream openstack tripleo team decided to move the tripleo_repos folder under plugins/module_utils/ openstack-archive/tripleo-repos@77dc579
Due to this, when building the ironic container, we end us with a 404 Not Found error.
Updating the script as per as the new upstream repo structure.

The upstream openstack tripleo team decided to move the `tripleo_repos` folder under `plugins/module_utils/` openstack-archive/tripleo-repos@77dc579
Due to this, when building the ironic container, we end us with a `404 Not Found` error.
Updating the script as per as the new upstream repo structure.
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2021
@elfosardo
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@elfosardo
Copy link
Member

/test-integration

Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to change the Dockerfile of the vbmc image resources/vbmc/Dockerfile

@metal3-io-bot metal3-io-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
@adetalhouet
Copy link
Contributor Author

adetalhouet commented Jul 27, 2021

we also need to change the Dockerfile of the vbmc image resources/vbmc/Dockerfile

Ok, done. Thanks for reviewing.

resources/vbmc/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
@elfosardo
Copy link
Member

/test-integration

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@elfosardo
Copy link
Member

/test-integration

1 similar comment
@furkatgofurov7
Copy link
Member

/test-integration

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@metal3-io-bot metal3-io-bot merged commit af6dfb0 into metal3-io:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants