Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ironic image for the quick-start #388

Closed
lentzi90 opened this issue Mar 8, 2024 · 2 comments · Fixed by #392
Closed

Pin ironic image for the quick-start #388

lentzi90 opened this issue Mar 8, 2024 · 2 comments · Fixed by #392
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

lentzi90 commented Mar 8, 2024

After metal3-io/ironic-image#479 was merged, the default changed to not use inspector. This breaks the quick-start guide since it is using BareMetalOperator v0.5.0 that assumes inspector is used.
We should pin the ironic-image to v24.0.0 to fix this and avoid similar issues going forward.

Add the following to the ironic kustomization in the quick-start:

images:
- name: quay.io/metal3-io/ironic
  newTag: v24.0.0
@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label Mar 8, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Mar 8, 2024

/triage accepted
/good-first-issue

@metal3-io-bot
Copy link
Contributor

@lentzi90:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants