Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ironic image version in kustomization.yaml example #392

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add ironic image version in kustomization.yaml example #392

merged 3 commits into from
Apr 18, 2024

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Mar 9, 2024 •
edited
Loading

Fix #388

@metal3-io-bot
Copy link
Contributor

Hi @lekaf974. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 9, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2024
@lekaf974
Add ironic image version in kustomization.yaml example
82dc947 
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974
Copy link
Contributor Author

/assign @lentzi90

lentzi90
lentzi90 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2024
tuminoid
tuminoid requested changes Apr 17, 2024
View reviewed changes
docs/user-guide/src/quick-start.md Outdated Show resolved Hide resolved
lekaf974 and others added 2 commits April 17, 2024 14:35
@lekaf974 @tuminoid
Remove non necessary indent
724020b 
Co-authored-by: Tuomo Tanskanen <tuomo@tanskanen.org>
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974 @tuminoid
Remove indent
cf3ff9c 
Co-authored-by: Tuomo Tanskanen <tuomo@tanskanen.org>
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974
Copy link
Contributor Author

@tuminoid changes done

tuminoid
tuminoid reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit c9b01fa into metal3-io:main Apr 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

@lentzi90 lentzi90 lentzi90 approved these changes

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin ironic image for the quick-start
4 participants
@lekaf974 @metal3-io-bot @tuminoid @lentzi90