Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the store interface #1335

Merged
merged 31 commits into from
Mar 12, 2020
Merged

Rewrite the store interface #1335

merged 31 commits into from
Mar 12, 2020

Conversation

jakexks
Copy link
Contributor

@jakexks jakexks commented Mar 12, 2020

This PR updates the store interface to be coherent with the design document.

Changes:

  • etcd and memory stores rewritten to be completely complaint with all possible options
  • cockroachdb, cloudflare and service stores updated to be compliant with the interface.

Jake Sanders and others added 28 commits March 4, 2020 18:14
WIP store rewrite
5c13150
Fix memory store tests
ef0206b
Store hard expiry times rather than duration!
f77aeb1
Clarify memory test
b08c219
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
171fe7c 
…te-store
Add limit to store interface
fc2ff19
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
95464cd 
…te-store
Implement suffix option
b4364cf
Don't return nils from noop store
4d01f39
Fix syncmap
18de8c0
Start fixing store service
47d1878
wip service and cache
40f5642
Use _ for special characters in cockroachdb namespace
bb9d9c8
Improve cockroach namespace comment
e5e26cb
Use service name as default store namespace
5eae57d
@ben-toogood
Merge branch 'store-namespace' into rewrite-store
0087e30
Fixes
aa8ec72
Implement Store Scope
3da92cf
@jakexks
Start fixing etcd
3347819
@jakexks
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
c63afb4 
…te-store
@jakexks
implement read and write with expiry and prefix
7978875
Fix etcd tests
2bb9acd
@jakexks
Fix cockroach store
bb5cbe8
@jakexks
Fix cloudflare interface
af904b5
@jakexks
Fix certmagic / cloudflare store
9e746bd
@jakexks
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
b32bfd8 
…te-store
@jakexks
comment lint
f22c0d3
@jakexks
cache isn't implemented yet
98196e9
vtolstov
vtolstov previously requested changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@vtolstov vtolstov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all prepared stuff to init tine to avoid reallocation

@jakexks jakexks merged commit 1b4e881 into master Mar 12, 2020
@jakexks jakexks deleted the rewrite-store branch March 12, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asim asim asim left review comments

@vtolstov vtolstov vtolstov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakexks @asim @vtolstov @ben-toogood