Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the store interface #1335

Merged
merged 31 commits into from
Mar 12, 2020
Merged

Rewrite the store interface #1335

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
5c13150
WIP store rewrite
Mar 4, 2020
ef0206b
Fix memory store tests
Mar 5, 2020
f77aeb1
Store hard expiry times rather than duration!
Mar 5, 2020
b08c219
Clarify memory test
Mar 5, 2020
171fe7c
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
Mar 5, 2020
fc2ff19
Add limit to store interface
Mar 5, 2020
95464cd
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
Mar 5, 2020
b4364cf
Implement suffix option
Mar 5, 2020
4d01f39
Don't return nils from noop store
Mar 5, 2020
18de8c0
Fix syncmap
Mar 5, 2020
47d1878
Start fixing store service
Mar 5, 2020
40f5642
wip service and cache
Mar 9, 2020
bb9d9c8
Use _ for special characters in cockroachdb namespace
Mar 9, 2020
e5e26cb
Improve cockroach namespace comment
Mar 9, 2020
5eae57d
Use service name as default store namespace
Mar 9, 2020
0087e30
Merge branch 'store-namespace' into rewrite-store
ben-toogood Mar 9, 2020
aa8ec72
Fixes
Mar 9, 2020
3da92cf
Implement Store Scope
Mar 9, 2020
3347819
Start fixing etcd
jakexks Mar 10, 2020
c63afb4
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
jakexks Mar 11, 2020
7978875
implement read and write with expiry and prefix
jakexks Mar 11, 2020
2bb9acd
Fix etcd tests
Mar 12, 2020
bb5cbe8
Fix cockroach store
jakexks Mar 12, 2020
af904b5
Fix cloudflare interface
jakexks Mar 12, 2020
9e746bd
Fix certmagic / cloudflare store
jakexks Mar 12, 2020
b32bfd8
Merge branch 'master' of https://github.com/micro/go-micro into rewri…
jakexks Mar 12, 2020
f22c0d3
comment lint
jakexks Mar 12, 2020
98196e9
cache isn't implemented yet
jakexks Mar 12, 2020
b1dc0ab
Merge branch 'master' into rewrite-store
Mar 12, 2020
707b9df
Only prepare DB staements once
jakexks Mar 12, 2020
a619c08
Merge branch 'rewrite-store' of https://github.com/micro/go-micro int…
jakexks Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve cockroach namespace comment
  • Loading branch information
Ben Toogood committed Mar 9, 2020
commit e5e26cba6bda36fb69e8b858cea23678e57ebe25
2 changes: 1 addition & 1 deletion store/cockroach/cockroach.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func (s *sqlStore) configure() error {
prefix = DefaultPrefix
}

// store.namespace must only contain letters
// store.namespace must only contain letters, numbers and underscores
reg, err := regexp.Compile("[^a-zA-Z0-9]+")
if err != nil {
return errors.New("error compiling regex for namespace")
Expand Down