Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0: Fix UPP drop bugs, add drop to the end of the list #15554

Merged
merged 8 commits into from
Oct 22, 2020
Merged

7.0: Fix UPP drop bugs, add drop to the end of the list #15554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36bad70
add drop at end of list, ability to disable drag drop
elisabethcvs Oct 16, 2020
422e815
update snapshots
elisabethcvs Oct 16, 2020
c5ab043
Change files
elisabethcvs Oct 16, 2020
af8d2f5
add onKeyDown prop
elisabethcvs Oct 20, 2020
ee25076
fix backspace check
elisabethcvs Oct 20, 2020
09d8e68
fix preventdefault
elisabethcvs Oct 21, 2020
0d137ca
Merge branch '7.0' into uppdropatend7.0
elisabethcvs Oct 21, 2020
433a6d6
regenerate snapshots after merge
elisabethcvs Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
regenerate snapshots after merge
  • Loading branch information
@elisabethcvs
elisabethcvs committed Oct 21, 2020
commit 433a6d6e2eb1afd2df1038c7346c94100573aa77
4 changes: 4 additions & 0 deletions ...ponents/UnifiedPicker/UnifiedPeoplePicker/__snapshots__/UnifiedPeoplePicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ exports[`UnifiedPeoplePicker renders correctly with no items 1`] = `
display: flex;
flex: 1 1 auto;
}
onDragOver={[Function]}
onDrop={[Function]}
role="combobox"
>
<input
Expand Down Expand Up @@ -786,6 +788,8 @@ exports[`UnifiedPeoplePicker renders correctly with selected and suggested items
display: flex;
flex: 1 1 auto;
}
onDragOver={[Function]}
onDrop={[Function]}
role="combobox"
>
<input
Expand Down
12 changes: 8 additions & 4 deletions packages/experiments/src/components/UnifiedPicker/__snapshots__/UnifiedPicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ exports[`UnifiedPicker renders correctly with no items 1`] = `
display: flex;
flex: 1 1 auto;
}
onDragOver={[Function]}
onDrop={[Function]}
role="combobox"
>
<input
Expand Down Expand Up @@ -171,14 +173,14 @@ exports[`UnifiedPicker renders correctly with selected and suggested items 1`] =
role="list"
>
<div>

red

</div>
<div>

green

</div>
</div>
<div
Expand All @@ -191,6 +193,8 @@ exports[`UnifiedPicker renders correctly with selected and suggested items 1`] =
display: flex;
flex: 1 1 auto;
}
onDragOver={[Function]}
onDrop={[Function]}
role="combobox"
>
<input
Expand Down