Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0: Fix UPP drop bugs, add drop to the end of the list #15554

Merged
merged 8 commits into from
Oct 22, 2020

Conversation

elisabethcvs
Copy link
Contributor

@elisabethcvs elisabethcvs commented Oct 16, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

V8 drag drop pr - #15428
V8 onKeyDown pr - #15623

  • Add props/functionality so that users can drop over the input (making it look like the item is dropped at the end of the list or in the empty UPP
  • add a prop so consumers can disable drag drop in the UPP
  • add a compare function to the selected items list so we don't have to rely on findIndex (which does a strict compare) to find the index of a list item
  • add onKeyDown function to the UnifiedPIcker so consumers can modify behavior

Modified the examples to show the new options:

  • double UPP example has everything enabled
  • single UPP has drag drop enabled, but not drop over the input
  • UPP with edit has drag drop disabled

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 16, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 433a6d6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 16, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 911 925 5000
BaseButton mount 1064 1005 5000
Breadcrumb mount 43527 43086 5000
ButtonNext mount 738 752 5000
Checkbox mount 1757 1775 5000
CheckboxBase mount 1473 1484 5000
ChoiceGroup mount 5465 5476 5000
ComboBox mount 986 985 1000
CommandBar mount 8139 8089 1000
ContextualMenu mount 13811 13804 1000
DefaultButton mount 1277 1256 5000
DetailsRow mount 3984 3998 5000
DetailsRowFast mount 4024 3893 5000
DetailsRowNoStyles mount 3773 3837 5000
Dialog mount 1602 1645 1000
DocumentCardTitle mount 1895 1914 1000
Dropdown mount 2817 2856 5000
FocusTrapZone mount 1805 1820 5000
FocusZone mount 1922 1913 5000
IconButton mount 1951 1965 5000
Label mount 364 372 5000
Layer mount 2153 2145 5000
Link mount 500 495 5000
MenuButton mount 1634 1628 5000
MessageBar mount 2180 2194 5000
Nav mount 3661 3516 1000
OverflowSet mount 1511 1528 5000
Panel mount 1563 1551 1000
Persona mount 928 960 1000
Pivot mount 1559 1563 1000
PrimaryButton mount 1411 1406 5000
Rating mount 8559 8422 5000
SearchBox mount 1408 1439 5000
Shimmer mount 2863 2883 5000
Slider mount 1642 1607 5000
SpinButton mount 5423 5430 5000
Spinner mount 452 447 5000
SplitButton mount 3509 3502 5000
Stack mount 561 569 5000
StackWithIntrinsicChildren mount 1811 1756 5000
StackWithTextChildren mount 5355 5309 5000
SwatchColorPicker mount 11345 11235 5000
TagPicker mount 2949 3156 5000
TeachingBubble mount 52747 52797 5000
Text mount 499 479 5000
TextField mount 1554 1612 5000
ThemeProvider mount 1805 1791 5000
ThemeProvider virtual-rerender 668 649 5000
Toggle mount 911 896 5000
button mount 132 126 5000

@size-auditor
Copy link

size-auditor bot commented Oct 16, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b7f88774119cfb65333380c70d06384764c0675b (build)

@elisabethcvs elisabethcvs reopened this Oct 21, 2020
@elisabethcvs elisabethcvs removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 21, 2020
@elisabethcvs elisabethcvs changed the title Fix UPP drop bugs, add drop to the end of the list 7.0: Fix UPP drop bugs, add drop to the end of the list Oct 21, 2020
@elisabethcvs elisabethcvs merged commit 002ca5c into microsoft:7.0 Oct 22, 2020
@elisabethcvs elisabethcvs deleted the uppdropatend7.0 branch October 22, 2020 17:45
@msft-github-bot
Copy link
Contributor

🎉@uifabric/experiments@v7.35.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.8.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants