Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPP: Add onKeyDown prop #15623

Merged
merged 3 commits into from
Oct 21, 2020
Merged

UPP: Add onKeyDown prop #15623

merged 3 commits into from
Oct 21, 2020

Conversation

elisabethcvs
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Add a prop for onKeyDown so the consumer has the ability to modify that

I did test that this works by adding the overload to an example, but didn't feel like it added to the example to check it in

nebhatna
nebhatna suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@nebhatna nebhatna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment :)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 839 849 5000
BaseButtonCompat mount 918 942 5000
Breadcrumb mount 161611 162046 5000
Checkbox mount 1506 1511 5000
CheckboxBase mount 1284 1281 5000
ChoiceGroup mount 4738 4756 5000
ComboBox mount 946 985 1000
CommandBar mount 22113 21929 1000
ContextualMenu mount 6131 6147 1000
DefaultButtonCompat mount 1133 1132 5000
DetailsRow mount 3628 3672 5000
DetailsRowFast mount 3748 3684 5000
DetailsRowNoStyles mount 3519 3486 5000
Dialog mount 1521 1565 1000
DocumentCardTitle mount 1879 1902 1000
Dropdown mount 3442 3403 5000
FocusTrapZone mount 1851 1849 5000
FocusZone mount 1832 1875 5000
IconButtonCompat mount 1801 1761 5000
Label mount 335 340 5000
Layer mount 1845 1818 5000
Link mount 470 462 5000
MenuButtonCompat mount 1473 1496 5000
MessageBar mount 2050 2067 5000
Nav mount 3301 3250 1000
OverflowSet mount 1048 1080 5000
Panel mount 1385 1455 1000
Persona mount 893 872 1000
Pivot mount 1393 1408 1000
PrimaryButtonCompat mount 1302 1322 5000
Rating mount 7496 7478 5000
SearchBox mount 1345 1322 5000
Shimmer mount 2545 2560 5000
Slider mount 1943 1973 5000
SpinButton mount 5259 5099 5000
Spinner mount 416 435 5000
SplitButtonCompat mount 3193 3215 5000
Stack mount 520 510 5000
StackWithIntrinsicChildren mount 1495 1541 5000
StackWithTextChildren mount 4651 4679 5000
SwatchColorPicker mount 10224 10364 5000
TagPicker mount 2755 2843 5000
TeachingBubble mount 11564 11794 5000
Text mount 451 420 5000
TextField mount 1355 1380 5000
ThemeProvider mount 2024 2024 5000
ThemeProvider virtual-rerender 650 658 5000
Toggle mount 802 827 5000
button mount 572 563 5000
buttonNative mount 99 124 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.52 0.87:1 2000 898
🦄 Button.Fluent 0.12 0.23 0.52:1 5000 575
🔧 Checkbox.Fluent 0.66 0.34 1.94:1 1000 658
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 808
🔧 Dropdown.Fluent 3 0.4 7.5:1 1000 2997
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 757
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 391
🔧 Slider.Fluent 1.61 0.46 3.5:1 1000 1609
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 378
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 596

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 180 164 1.1:1
PortalMinimalPerf.default 183 170 1.08:1
Icon.Fluent 757 708 1.07:1
ChatMinimalPerf.default 652 618 1.06:1
CardMinimalPerf.default 592 563 1.05:1
CarouselMinimalPerf.default 478 457 1.05:1
LabelMinimalPerf.default 447 427 1.05:1
ReactionMinimalPerf.default 436 416 1.05:1
ListMinimalPerf.default 523 501 1.04:1
TooltipMinimalPerf.default 873 841 1.04:1
TreeWith60ListItems.default 226 218 1.04:1
AlertMinimalPerf.default 329 319 1.03:1
FormMinimalPerf.default 439 425 1.03:1
GridMinimalPerf.default 387 377 1.03:1
HeaderMinimalPerf.default 405 392 1.03:1
RadioGroupMinimalPerf.default 464 452 1.03:1
TextAreaMinimalPerf.default 519 502 1.03:1
TreeMinimalPerf.default 934 907 1.03:1
Tooltip.Fluent 596 576 1.03:1
BoxMinimalPerf.default 375 369 1.02:1
DropdownManyItemsPerf.default 776 759 1.02:1
ItemLayoutMinimalPerf.default 1290 1268 1.02:1
LoaderMinimalPerf.default 755 739 1.02:1
MenuMinimalPerf.default 898 880 1.02:1
MenuButtonMinimalPerf.default 1621 1591 1.02:1
PopupMinimalPerf.default 741 725 1.02:1
SliderMinimalPerf.default 1629 1593 1.02:1
TableManyItemsPerf.default 2244 2206 1.02:1
ButtonOverridesMissPerf.default 1750 1728 1.01:1
ButtonUseCssNestingPerf.default 1118 1111 1.01:1
CheckboxMinimalPerf.default 2903 2883 1.01:1
DialogMinimalPerf.default 818 810 1.01:1
DividerMinimalPerf.default 396 393 1.01:1
LayoutMinimalPerf.default 435 431 1.01:1
ListCommonPerf.default 653 644 1.01:1
ListNestedPerf.default 601 594 1.01:1
ListWith60ListItems.default 950 945 1.01:1
ProviderMergeThemesPerf.default 2163 2146 1.01:1
SegmentMinimalPerf.default 382 380 1.01:1
SkeletonMinimalPerf.default 440 436 1.01:1
CustomToolbarPrototype.default 4004 3972 1.01:1
Avatar.Fluent 898 893 1.01:1
Button.Fluent 575 572 1.01:1
Checkbox.Fluent 658 651 1.01:1
AnimationMinimalPerf.default 428 430 1:1
AttachmentMinimalPerf.default 178 178 1:1
ChatDuplicateMessagesPerf.default 441 440 1:1
ChatWithPopoverPerf.default 485 487 1:1
DropdownMinimalPerf.default 2990 2994 1:1
EmbedMinimalPerf.default 1951 1945 1:1
ImageMinimalPerf.default 408 408 1:1
ProviderMinimalPerf.default 1023 1020 1:1
StatusMinimalPerf.default 750 750 1:1
TextMinimalPerf.default 381 381 1:1
ToolbarMinimalPerf.default 961 965 1:1
Slider.Fluent 1609 1612 1:1
Text.Fluent 378 377 1:1
AvatarMinimalPerf.default 481 484 0.99:1
ButtonSlotsPerf.default 611 618 0.99:1
FlexMinimalPerf.default 313 316 0.99:1
HeaderSlotsPerf.default 807 819 0.99:1
InputMinimalPerf.default 1333 1347 0.99:1
RefMinimalPerf.default 248 250 0.99:1
SplitButtonMinimalPerf.default 3789 3815 0.99:1
TableMinimalPerf.default 434 438 0.99:1
Dropdown.Fluent 2997 3017 0.99:1
Image.Fluent 391 396 0.99:1
ButtonMinimalPerf.default 184 188 0.98:1
ButtonUseCssPerf.default 827 846 0.98:1
Dialog.Fluent 808 823 0.98:1
AttachmentSlotsPerf.default 1131 1193 0.95:1
IconMinimalPerf.default 677 711 0.95:1
VideoMinimalPerf.default 618 648 0.95:1

@size-auditor
Copy link

size-auditor bot commented Oct 20, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b14a4ed22b4ea4cd45fa09a4a34f9ccfe71d32dd (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2c8a87:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@elisabethcvs elisabethcvs merged commit ac1cfd5 into microsoft:master Oct 21, 2020
@elisabethcvs elisabethcvs mentioned this pull request Oct 21, 2020
Merged
2 tasks
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@elisabethcvs
UPP: Add onKeyDown prop (microsoft#15623)
553415c 
* add prop for onKeyDown

* Change files

* address CR comments
@elisabethcvs elisabethcvs deleted the addkeydownprop branch November 9, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebhatna nebhatna nebhatna approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Component: UnifiedPicker Package: experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elisabethcvs @msft-github-bot @nebhatna @tomi-msft