Add missing act() in tests and fix other test issues #15636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecraig12345
requested review from
assuncaocharles,
atneik,
dzearing,
evlevy,
Jahnp,
joschect,
jurokapsiar,
kolaps33,
layershifter,
lorejoh12,
micahgodbolt,
miroslavstastny,
pompomon,
ThomasMichon,
Vitalius1 and
xugao
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0cc47cf:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesUnable to find bundle size details for Baseline commit: cfff925 Possible causes
Recommendations
|
ecraig12345
force-pushed
the
tests-act
branch
from
0e60b0f
to
84e2f7a
Compare
# Conflicts: # packages/react-internal/src/components/Calendar/Calendar.test.tsx # packages/react-internal/src/components/DatePicker/DatePicker.test.tsx
joschect
approved these changes
Oct 23, 2020
|
🎉 Handy links: |
SethDonohue
pushed a commit
to SethDonohue/fluentui
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Noticed while working on another PR that several components in react-internal were logging errors from their tests about missing
act()usage, but those errors weren't causing builds to fail. So this PR adds the missingact()wrappers AND fixes the logging so that errors like this will cause failures in the future. (The issue was that errors thrown in certain async scenarios were being eaten by our mockAsyncimplementation rather than thrown.)I also made some fixes to scripts/jest/jest-setup.js to reduce the verbosity of
act()-related errorsWhile working on the test fixes, I noticed that many places were using
expect(...).toBeDefined()in a way that seemed to assume that the assertion would fail fornullas well asundefined, which is NOT the case (it only checks forundefined). Depending on the circumstances, the fix is to use eitherexpect(...).toBeTruthy()orexpect(...).not.toBeNull(). I did a search and updated all the places where the usage seemed incorrect.