Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing act() in tests and fix other test issues #15636

Merged
merged 13 commits into from
Oct 23, 2020
Merged

Add missing act() in tests and fix other test issues #15636

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0014d1f
fix eslint warnings
ecraig12345 Oct 21, 2020
19ec826
Remove incorrect usage of expect.toBeDefined
ecraig12345 Oct 21, 2020
4b17595
Properly log and propagate async exceptions from tests
ecraig12345 Oct 21, 2020
61c54ac
Add act() in tests
ecraig12345 Oct 21, 2020
99a9bcf
Change files
ecraig12345 Oct 21, 2020
3b4ca6e
rename test files
ecraig12345 Oct 21, 2020
814f371
spelling
ecraig12345 Oct 21, 2020
84e2f7a
fix test issues hidden by toBeDefined
ecraig12345 Oct 22, 2020
f27f589
change file update
ecraig12345 Oct 22, 2020
f8ca36c
Merge branch 'master' into tests-act
ecraig12345 Oct 23, 2020
d81e292
change files again
ecraig12345 Oct 23, 2020
cd27246
Merge branch 'master' into tests-act
ecraig12345 Oct 23, 2020
0cc47cf
change fileeeee
ecraig12345 Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change fileeeee
  • Loading branch information
@ecraig12345
ecraig12345 committed Oct 23, 2020
commit 0cc47cf14bb046b46d993a6af02e49b6f590ff5e
2 changes: 1 addition & 1 deletion change/@uifabric-date-time-2020-10-21-16-15-31-tests-act.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "none",
"comment": "Remove incorrect usage of expect.toBeDefined",
"packageName": "@uifabric/date-time",
"packageName": "@fluentui/react-date-time",
"email": "elcraig@microsoft.com",
"dependentChangeType": "none",
"date": "2020-10-21T23:13:49.132Z"
Expand Down