Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert falsy tooltip change (#841) #842

Closed
bwateratmsft opened this issue Jan 29, 2021 · 1 comment · Fixed by #843
Closed

Revert falsy tooltip change (#841) #842

bwateratmsft opened this issue Jan 29, 2021 · 1 comment · Fixed by #843

Comments

@bwateratmsft
Copy link
Contributor

Once the upstream bug in VSCode is fixed, we should revert the change in #841, so we can return the decision of how to handle a falsy label to VSCode. (Currently VSCode uses the label, and we now have logic duplicating that behavior; but ideally we should remove that logic when possible)
@bwateratmsft bwateratmsft self-assigned this Jan 29, 2021
@bwateratmsft bwateratmsft mentioned this issue Jan 29, 2021
Merged
@bwateratmsft
Copy link
Contributor Author

The upstream fix is done now, so I'll revert the change here.

@bwateratmsft bwateratmsft mentioned this issue Feb 1, 2021
Merged
@bwateratmsft bwateratmsft removed their assignment Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert falsy tooltip change microsoft/vscode-azuretools
1 participant
@bwateratmsft