Revert falsy tooltip change #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPDATE: Verified the fix! |
|
Can you comment on the timing of this? When was the bug introduced in VS Code and when was it fixed? Are we at risk of people on older versions of VS Code still seeing the bug? If so, it doesn't seem that bad to leave the workaround in |
|
@ejizba the bug was introduced in Insiders 1.53 late last year and just fixed yesterday; it hasn't appeared in any GA builds of VSCode yet. So, removing the fix (i.e. submitting this PR) should be fine, since it would only affect a few folks on Insiders until they upgraded. |
ejizba
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #841, fixes #842. The upstream VSCode issue has been fixed so we should go back to our old behavior.