Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert falsy tooltip change #843

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Revert falsy tooltip change #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vscode-azureextensionui",
"author": "Microsoft Corporation",
"version": "0.38.5",
"version": "0.38.6",
"description": "Common UI tools for developing Azure extensions for VS Code",
"tags": [
"azure",
Expand Down
5 changes: 0 additions & 5 deletions ui/src/tree/AzExtTreeDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ export class AzExtTreeDataProvider implements IAzExtTreeDataProviderInternal, ty
ti.tooltip = await treeItem.resolveTooltip();
}

// If the tooltip is falsy, change it to the label--otherwise, it will be stuck on 'Loading...'
// (VSCode sees there's a `resolveTreeItem` method, so it tries resolving, but only replaces 'Loading...' with your tooltip if your tooltip is truthy)
// Label is the default behavior if tooltip is falsy, so we'll supply that
ti.tooltip = ti.tooltip || ti.label;

return ti;
}

Expand Down