Merge Settings editor labels into a single group (#142045)

Refactor Settings editor labels to be under a single group. Also fix VoiceOver support on macOS for those labels. Fixes #107748 Fixes #141960
microsoft · Feb 3, 2022 · 870ab1e · 870ab1e
1 parent 7455bc4
commit 870ab1e
Show file tree

Hide file tree

Showing 2 changed files with 184 additions and 108 deletions.
diff --git a/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css b/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css
@@ -314,6 +314,10 @@
 	display: inline-block; /* size to contents for hover to show context button */
 }
 
+.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .comma {
+	padding-right: 4px;
+}
+
 .settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-modified-indicator {
 	display: none;
 }
@@ -335,18 +339,8 @@
 	bottom: 23px;
 }
 
-.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .setting-item-overrides {
+.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title > .misc-label {
 	font-style: italic;
-	margin-right: 4px;
-}
-
-.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .setting-item-ignored,
-.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .setting-item-default-overridden {
-	font-style: italic;
-}
-
-.settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .setting-item-default-overridden {
-	margin-right: 4px;
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-title .setting-item-ignored .codicon,