Merge labels into a single group #142045
Merged
Merge labels into a single group #142045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Feb 2, 2022
| this.ignoredSettings = getIgnoredSettings(getDefaultIgnoredSettings(), this._configService); | ||
| this._onDidChangeIgnoredSettings.fire(); | ||
| } | ||
| this.ignoredSettings = getIgnoredSettings(getDefaultIgnoredSettings(), this._configService); |
There was a problem hiding this comment.
Note: we fire the event more often here by taking out the if case, because otherwise, OSS doesn't seem to update this.ignoredSettings when the extension settings finally get loaded.
miguelsolorio
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
LGTM, only have a minor nit for spacing. Also might be worth exploring some alternate ways to layout all of the labels as they seem to be growing and are quite compact
cc @lychung7
raghavthind2005
approved these changes
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107748
Fixes #141960
This PR merges the Settings editor setting side labels into a single group per setting.
We define the side labels as the HTML elements that sometimes show up to the right of setting titles, such as the sync ignored indicator or the default overridden indicator.
At the same time, the PR also adds aria support for those side labels, so that programs such as VoiceOver on macOS can read out that information.