Implement Find All command & button #33829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickguletskii, It will cover your contributions to all Microsoft-managed open source projects. |
|
@nickguletskii, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Turns out Github's issue search sucks and there's already a pull request for this: #7559 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a Find All command and button which selects and adds multicursors to all matches in the file. This functionality is available in Sublime and I was a bit jealous, so I've decided I would implement it for VS Code. I understand that this contains a change to the UI, so I won't be upset if the UX team rejects this pull request, as I haven't discussed this feature with anyone before implementing it.
Usage examples
Simple editing using multi-cursors:
Extracting matches:
Further info
This pull request contains a placeholder icon I hacked up from other icons in VS Code's source, and it probably doesn't really match VS Code's search iconography.
This pull request doesn't contain any localisations.