Add find all button #7559

yisibl · 2016-06-11T12:12:10Z

mention-bot · 2016-06-11T12:12:12Z

By analyzing the blame information on this pull request, we identified @Inori and @alexandrudima to be potential reviewers

msftclas · 2016-06-11T12:12:15Z

Hi @yisibl, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas · 2016-06-12T03:06:01Z

@yisibl, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

rebornix · 2016-06-12T04:12:09Z

i18n/chs/src/vs/editor/contrib/find/browser/findWidget.i18n.json

 	"label.nextMatchButton": "下一个匹配",
 	"label.noResults": "无结果",
 	"label.previousMatchButton": "上一个匹配",
+	"label".allMatchButton": "选中所有匹配",


I think we don't modify locaization files ourselves, only touch the English version.

@rebornix Do you mean that do not modify the localization file? Should I submit a PR to increase localization translation?

yup, just leave it there, it will be handled by the localization team.

Done!
By the way, how do I open a localized UI to vscode after the source code is compiled?

I removed the localized changes.

yisibl · 2016-06-14T03:31:53Z

@alexandrudima This can be merge?

alexdima · 2016-06-26T16:30:39Z

I would like to bring in our UX folks on this, rather than just merging it in and get their advice on how we can add functionality to the find widget without overdoing it.

@stevencl @bgashler1 Can I please get your opinion on this proposal?

yisibl · 2016-06-27T02:38:10Z

@alexandrudima Thanks!

stevencl · 2016-06-27T13:54:21Z

I really like the idea. We might consider doing something similar to Visual Studio. Instead of three separate buttons for find next, find previous and find all, VS has a button with a drop down that allows you to select the specific action you want to use. So it would look something like this mockup (showing what the user sees when they click the drop down):

The idea would be that you click on the drop down next to the button to run and then change the command. So if you click Find Previous in the drop down, the button changes to the Find Previous button. If you click Find All, the button changes to the Find All button etc.

@bgashler1 might have some other, better ideas. I haven't spoken with him about this today.

yisibl · 2016-06-28T02:06:03Z

@stevencl

I am more inclined to the 100% width of the search box, and the height is adaptive. Now the search box is too short, and the preparation of the code when you may often need to search for a relatively long code fragment. If it is a 100% width search box, then there is no need to fold(drop down) the buttons.

Sublime Text:

By the way, usually the focus of our vision is on the left, especially when full screen writing code, usually we will set up more than 80 characters automatically wrap. So now the search box aligned to the right, I think the user experience is not good.

Anyway I expect the next version can be added to find all button.

Thanks!

stevencl · 2016-06-28T08:35:21Z

Thanks @yisibl. I understand the points you are making about the current find experience.

As you've pointed out, Sublime has a very different user experience for find and find in files. We use the small box for find and a viewlet for find in files so that we minimise the extent to which we interfere with the code that the user is browsing.

In order to accommodate richer find interactions such as the one you are proposing here we need to ensure that we minimise the amount of code we obscure when we draw the find UI. Hence my suggestion above (and the reason why we align the find UI to the right).

So without any major modifications to the current find UI, I would recommend the drop down button to expose the Find All command. That way we incorporate the new functionality without requiring major changes to the overall find UX.

rebornix · 2017-05-26T16:44:57Z

I'll review this PR in next iteration when I do full width find widget.

yisibl · 2017-05-31T02:40:46Z

@rebornix Where's the plan for "full width find widget"?

yisibl · 2019-09-04T06:14:49Z

I have re-updated this feature, please review.

@alexandrudima I'm not sure if the click button should call this.closeFindWidget() to close the FindWidget.I tend to close it, otherwise there will be a highlighting prompt to interfere with the user editing the text.

ilixindri · 2021-04-16T02:29:21Z

@stevencl use for all (∀) symbol.

ghost · 2021-09-11T12:41:48Z

Best to design another codicon for it

ghost · 2021-09-17T18:23:07Z

I have logged a issue for adding a bespoke icon specifically for this pull and other uses of "select all" in the UI

ghost · 2022-06-30T21:55:44Z

It's embarrassing that this is 6 years old!

byehack · 2022-10-05T18:34:25Z

Find all button in other places is usually for show list of them, not select!
Btw I hope it will add by #158598 (comment)

Just an idea:
Change the color of number of founds and make it clickable.
Click on it should go to search panel with seed of current search and just include current file.
(It could have support CTRL+click to find in all files.)
Details can go under hovering.

Also, there is an extension currently do this but main problem there is no way to back previous state of search panel. (it could solve with using search editor)

zm-cttae · 2023-01-24T22:50:21Z

I personally think the caption should be "Select All Matches" like the exploration done in #14836.
The icon could just be expand-all or plus which is the best analog in the UI for "multi-target actions"

zm-cttae

@yisibl This conflicts with the new orthogonal "Find all" new window button implemented #128915 and the naming is internally inconsistent.

As some context, the #14836 issue split into two feature requests:
1. "Find all" `new-file` icon to launch a new search editor file
2. "Select all matches" `expand-all` icon

I'll try and make some suggestions ... this review should hopefully get us a working "select all" button.

zm-cttae · 2023-02-02T18:46:10Z

Nvm I will make a PR to your fork branch and see if I can reup this. yisibl#1

zm-cttae · 2023-02-08T10:16:40Z

@miguelsolorio your thoughts please on the UI/UX recommendation in #14836 (comment).
If core team is happy, reup PR is ready to go.

zm-cttae · 2023-03-02T07:26:42Z

@daviddossett @joyceerhl @bpasero @lszomoru @miguelsolorio could one of you take PR assignee targeting April iteration? We want to reup this - #14836 (comment)

heartacker · 2024-04-06T01:45:03Z

hi, @rebornix , could you please take a look

ruru-m07

👍

msftclas added the cla-required label Jun 11, 2016

msftclas added cla-signed and removed cla-required labels Jun 12, 2016

rebornix reviewed Jun 12, 2016
View reviewed changes

bpasero assigned alexdima Jun 13, 2016

alexdima added the ux User experience issues label Jun 26, 2016

alexdima added this to the Backlog milestone Jul 5, 2016

alexdima mentioned this pull request Aug 5, 2016

Hope to add function of 'Find All' #10161

Closed

alexdima assigned rebornix May 16, 2017

alexdima added the editor-find Editor find operations label May 16, 2017

rebornix modified the milestones: June 2017, Backlog May 26, 2017

rebornix mentioned this pull request May 26, 2017

multiselect by regex #27119

Closed

kieferrm modified the milestones: July 2017, June 2017 Jul 6, 2017

rebornix modified the milestones: Backlog, July 2017 Jul 27, 2017

nickguletskii mentioned this pull request Sep 5, 2017

Implement Find All command & button #33829

Closed

msftgits removed the cla-signed label Sep 26, 2017

Implement again to find all button (2019)

4cda900

yisibl force-pushed the add-find-all-button branch from c1a1a21 to 4cda900 Compare September 4, 2019 06:04

Merge branch 'master' into add-find-all-button

4f8b579

rebornix added the feature-request Request for new features or functionality label Oct 8, 2020

joaomoreno changed the base branch from master to main February 15, 2021 08:51

ghost mentioned this pull request Sep 16, 2021

select-all or find-all microsoft/vscode-codicons#83

Closed

rebornix removed their assignment Oct 22, 2021

alexdima dismissed stale reviews from fosslinux, nzec, and ghost via 4f8b579 May 5, 2022 09:18

miguelsolorio removed their assignment Jul 19, 2022

zm-cttae suggested changes Feb 2, 2023

View reviewed changes

zm-cttae mentioned this pull request Feb 4, 2023

Refactor microsoft#7559 into "Select Matches" icon yisibl/vscode#1

Open

alexdima assigned rebornix Sep 25, 2023

alexdima removed the feature-request Request for new features or functionality label Sep 25, 2023

samuelrizzo approved these changes Feb 20, 2024

View reviewed changes

zC4sTr0 approved these changes Feb 20, 2024

View reviewed changes

ruru-m07 approved these changes Apr 11, 2024

View reviewed changes

samuelrizzo approved these changes Apr 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add find all button #7559

Add find all button #7559

yisibl commented Jun 11, 2016 •

edited

Loading

mention-bot commented Jun 11, 2016

msftclas commented Jun 11, 2016

msftclas commented Jun 12, 2016

rebornix Jun 12, 2016

yisibl Jun 12, 2016

rebornix Jun 12, 2016

rebornix Jun 12, 2016

yisibl Jun 12, 2016 •

edited

Loading

yisibl Sep 3, 2019

yisibl commented Jun 14, 2016

alexdima commented Jun 26, 2016

yisibl commented Jun 27, 2016

stevencl commented Jun 27, 2016

yisibl commented Jun 28, 2016 •

edited

Loading

stevencl commented Jun 28, 2016

rebornix commented May 26, 2017

yisibl commented May 31, 2017

yisibl commented Sep 4, 2019

ilixindri commented Apr 16, 2021

ghost commented Sep 11, 2021

ghost commented Sep 17, 2021 •

edited by ghost

Loading

ghost commented Jun 30, 2022

byehack commented Oct 5, 2022

zm-cttae commented Jan 24, 2023

zm-cttae left a comment

zm-cttae commented Feb 2, 2023 •

edited

Loading

zm-cttae commented Feb 8, 2023 •

edited

Loading

zm-cttae commented Mar 2, 2023

heartacker commented Apr 6, 2024

ruru-m07 left a comment

Add find all button #7559

Are you sure you want to change the base?

Add find all button #7559

Conversation

yisibl commented Jun 11, 2016 • edited Loading

mention-bot commented Jun 11, 2016

msftclas commented Jun 11, 2016

msftclas commented Jun 12, 2016

rebornix Jun 12, 2016

Choose a reason for hiding this comment

yisibl Jun 12, 2016

Choose a reason for hiding this comment

rebornix Jun 12, 2016

Choose a reason for hiding this comment

rebornix Jun 12, 2016

Choose a reason for hiding this comment

yisibl Jun 12, 2016 • edited Loading

Choose a reason for hiding this comment

yisibl Sep 3, 2019

Choose a reason for hiding this comment

yisibl commented Jun 14, 2016

alexdima commented Jun 26, 2016

yisibl commented Jun 27, 2016

stevencl commented Jun 27, 2016

yisibl commented Jun 28, 2016 • edited Loading

stevencl commented Jun 28, 2016

rebornix commented May 26, 2017

yisibl commented May 31, 2017

yisibl commented Sep 4, 2019

ilixindri commented Apr 16, 2021

ghost commented Sep 11, 2021

ghost commented Sep 17, 2021 • edited by ghost Loading

ghost commented Jun 30, 2022

byehack commented Oct 5, 2022

zm-cttae commented Jan 24, 2023

zm-cttae left a comment

Choose a reason for hiding this comment

zm-cttae commented Feb 2, 2023 • edited Loading

zm-cttae commented Feb 8, 2023 • edited Loading

zm-cttae commented Mar 2, 2023

heartacker commented Apr 6, 2024

ruru-m07 left a comment

Choose a reason for hiding this comment

yisibl commented Jun 11, 2016 •

edited

Loading

yisibl Jun 12, 2016 •

edited

Loading

yisibl commented Jun 28, 2016 •

edited

Loading

ghost commented Sep 17, 2021 •

edited by ghost

Loading

zm-cttae commented Feb 2, 2023 •

edited

Loading

zm-cttae commented Feb 8, 2023 •

edited

Loading