Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty route object in routeFinishedSetup #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Yubin
Copy link

@Yubin Yubin commented Nov 15, 2016

Hi Mike, I hope everything is fine.
Currently we are going to adopt ember-perf. But found a little issue:

Transition data's activateRoute function won't call when my routes have already use active() hook which causing route object is missing in transition-data. So I think Empty route object has better to be checked in routeFinishedSetup of transition-data.

Yubin

@galfert
Copy link

galfert commented Jan 16, 2017

Are you calling this._super(...arguments); from your activate() hook? That should be enough so that ember-perf's activate() is called as well.

I found some scenarios though, in which the activate() won't get called nonetheless. I reported those in #83.

Jiahan Wang and others added 2 commits March 23, 2017 15:27
@kiwiupover
Copy link
Collaborator

Can we add a test for this case? @Yubin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants