Remove --allow-external #1198
Merged
Remove --allow-external #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-serdyuk
force-pushed
the
update-reqs
branch
from
ad0962e
to
e0d385d
Compare
|
CI fail. |
|
It could need the same fix as I did in Fuel (define an env variable MKL_THREADING_LAYER=GNU) |
|
Fixed |
|
2 CI still fail. I think a new version of pep8 is used. That caused a failure in Fuel |
|
Ok, I figured out the problem. Virtualenv puts a bunch of its things into |
|
@nouiz I give up. I was tinkering for quite a while. I fixed Travis and Scrutinizer tests. But I have no idea what happens to Scrutinizer analysis. |
|
So, what do we do? As the tests passed, we could merge. This would fix possible security issue, so I would go in that direction. |
|
OK, let me cleanup history then
…On Thu, Sep 6, 2018, 02:10 Frédéric Bastien ***@***.***> wrote:
So, what do we do? As the tests passed, we could merge. This would fix
possible security issue, so I would go in that direction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACvVJ4aSpIr3aPKrDoVCYyhSFRVs042qks5uYDaxgaJpZM4WSLx3>
.
|
dmitriy-serdyuk
force-pushed
the
update-reqs
branch
from
d6e45d0
to
05bd45f
Compare
dmitriy-serdyuk
force-pushed
the
update-reqs
branch
from
05bd45f
to
c79f01f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mila-iqia/fuel#405
@nouiz