Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Pillow to be sure it is a secure version #405

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Bump Pillow to be sure it is a secure version #405

merged 3 commits into from
Sep 6, 2018

Conversation

nouiz
Copy link
Contributor

@nouiz nouiz commented Aug 28, 2018

No description provided.

dmitriy-serdyuk
dmitriy-serdyuk reviewed Aug 28, 2018
View reviewed changes
.travis.yml Outdated
fi
- chmod +x miniconda.sh
- ./miniconda.sh -b -p $HOME/miniconda
- export PATH=$HOME/miniconda/bin:$PATH
- conda update -q --yes conda
# - conda update -q --yes conda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line? I don't see a reason to have it commented.

@dmitriy-serdyuk
Copy link
Contributor

Some tests fail with the new pillow FAIL: tests.transformers.test_image.TestRandom2DRotation.test_random_2D_rotation_batch_stream. I think their defaults changed.

@dmitriy-serdyuk
Copy link
Contributor

It looks like the old pillow had a bug there. I tested on images of bigger sizes and pillow 3.4 -- 5.2 works fine and the same here.

Not sure why old pillow had this answer, but in this test the rotation angle is 12.25 degrees. It means that the difference in the output image will be less than 1 pixel. So, the new pillow is giving the right answer.

@dmitriy-serdyuk dmitriy-serdyuk mentioned this pull request Aug 29, 2018
Merged
@dmitriy-serdyuk
Copy link
Contributor

Basically, it fails now only because of --allow-external in blocks. I removed it in mila-iqia/blocks#1198.

Feel free to merge both PRs.

@dmitriy-serdyuk
Copy link
Contributor

Tests passed, I merge

@dmitriy-serdyuk dmitriy-serdyuk merged commit f8e0eee into master Sep 6, 2018
@dmitriy-serdyuk dmitriy-serdyuk mentioned this pull request Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitriy-serdyuk dmitriy-serdyuk dmitriy-serdyuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nouiz @dmitriy-serdyuk @vrodr1guez