Housekeeping #495
Merged
Housekeeping #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version mirrors ProcessNewCreditsForm.credit_choices
Using callables for arg defaults is not recommended; also, this default was never really used to getting rid of it should be safe.
All calls reuse one instance of that data structure, persisting changes between them.
flake8-bugbear suggests: Do not call setattr with a constant attribute value, it is not any safer than normal property access. The new version is also easier to read. This also adds a missing test for the related lines of code.
ushkarev
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
The intention is to eventually add
flake8-bugbearandflake8-quotesto mtp_common.