Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping #495

Merged
merged 6 commits into from
Jul 8, 2019
Merged

Housekeeping #495

merged 6 commits into from
Jul 8, 2019

Commits on Jul 4, 2019

  1. Update README with info about venv name

    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    c7cf6f7 View commit details
    Browse the repository at this point in the history

  2. Make ProcessManualCreditsForm.credit_choices consistent 

    The new version mirrors ProcessNewCreditsForm.credit_choices
    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    ffc224e View commit details
    Browse the repository at this point in the history

  3. Remove unused logger

    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    bc916ea View commit details
    Browse the repository at this point in the history

  4. Remove unused default from insert_blank_option 

    Using callables for arg defaults is not recommended; also, this
default was never really used to getting rid of it should be safe.
    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    52e6091 View commit details
    Browse the repository at this point in the history

  5. Avoid using mutable data structure for arg default 

    All calls reuse one instance of that data structure, persisting
changes between them.
    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    399830b View commit details
    Browse the repository at this point in the history

  6. Avoid using setattr with constant attribute value 

    flake8-bugbear suggests:
Do not call setattr with a constant attribute value, it is not
any safer than normal property access.

The new version is also easier to read.

This also adds a missing test for the related lines of code.
    @marcofucci
    marcofucci committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    4d82338 View commit details
    Browse the repository at this point in the history