Fixing (some) stalled GUI during iTunes import #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the gui stall issue from lp1785545
|
Travis GCC build fails unrelated to this PR |
Conflicts: src/library/itunes/itunesfeature.cpp
|
Is this a 2.1.5 candidate? It matters a lot for people with a big iTunes library. How much are there? |
|
I neither have a ready to use Windows development environment nor an iTunes library for testing. Code LGTM so far. The only actual change is clearing the existing table contents before re-importing them from the XML? Well, since the contents of those tables is simply a cache reflecting a snapshot of the XML during the last import this is non-crititcal, even if the following import fails. |
|
I moved the table clear to an early point to not show outdated tables if the import fails. |
|
Thank you for review. |
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not perfect, but it is now usable even for bigger iTunes libraries.
https://bugs.launchpad.net/mixxx/+bug/1785545