Scratch on first wheel touch #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
approved these changes
May 18, 2022
|
Hey! I was encountering this bug too! I was trying to explain this in 2020 But I guess I didn't do it very well so nobody got it. Thank god it is fixed now! |
|
Alright.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes lp:1800343 No scratching on touching jog wheel for the first time
When touching the wheel
scratchEnabledoes indeed enable scratching, thoughscratchProcesswould disable it right away due to false-positivem_softStartActive(and interpret the wheel turn asjogcommand), or even stop the deck due to false-positivem_brakeActiveorm_spinbackActive(regression from #4708 I think).Either of those issues occurs, or it just works.
Initializing all related deck bools with
falsefixes the issue for me.I don't know how this could be related to using the controller's sound card though (as reported in the bug).