Fix \n not being escaped properly

[mmena1]

Summary by CodeRabbit

• New Features
  • Removed extra [Y/n] that was being displayed on the prompt.
  • Improved formatting for the sudoers configuration to ensure proper functionality.

[coderabbitai]

Walkthrough

The changes involve modifications to the setup_passwordless_sudo function within a script. The user prompt for enabling passwordless sudo has been simplified by removing the explicit confirmation option. Additionally, the method for writing the NOPASSWD entry to a temporary file has been updated to utilize echo -e, allowing for proper interpretation of escape sequences, particularly the newline character. These changes aim to enhance user interaction and ensure correct formatting of the sudoers entry.

Changes

Files	Change Summary
home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl	Modified prompt message for passwordless sudo to simplify user interaction; changed method of writing NOPASSWD entry to use echo -e for correct escape sequence processing.

Poem

In the burrow where scripts do play,
A prompt was changed to brighten the day.
With echoes that dance and newline delight,
Passwordless sudo now feels just right!
Hopping along, we cheer with glee,
For simpler paths, oh joy, oh me! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d79858d and 20cf647.

Files selected for processing (1)

• home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl (2 hunks)

Additional comments not posted (2)

home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl (2)

26-26: LGTM!

The simplification of the user prompt aligns with the PR objective and enhances user interaction by presenting a straightforward question.

---

35-35: Excellent fix!

Using echo -e to interpret the escape sequences, particularly the newline character, ensures the correct formatting of the sudoers entry in the temporary file. This change aligns perfectly with the PR objective of fixing the improper escaping of \n.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.