Fix some issues with the Ubuntu setup

[mmena1]

Summary by CodeRabbit

• New Features

  • Added Git to the list of installable packages, enhancing version control capabilities.
  • Improved the initialization process for the asdf environment post-installation.

• Bug Fixes

  • Enhanced security by ensuring correct ownership of the sudoers file and related directories.

• Improvements

  • Streamlined Docker installation process by reducing terminal output during installation.

[coderabbitai]

Walkthrough

The pull request introduces several changes across multiple scripts and configuration files. Notably, it adds 'git' to the debian-packages.yaml file, enhancing the available tools for installation. Additionally, it modifies the setup_passwordless_sudo function to ensure proper ownership of the /etc/sudoers directory. The installation process for asdf is updated to source its script immediately after cloning, and Docker installation commands are adjusted to reduce output verbosity.

Changes

File Path	Change Summary
home/.chezmoidata/debian-packages.yaml	Added 'git' to the list of packages.
home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl	Modified setup_passwordless_sudo to change ownership of /etc/sudoers and /etc/sudoers.d back to root.
home/.chezmoiscripts/run_once_after_02-asdf-install.sh.tmpl	Updated install_asdf to source asdf.sh immediately after cloning the repository.
home/.chezmoiscripts/run_once_after_03-docker-setup.sh.tmpl	Added -qq flag to apt-get commands to suppress output during Docker installation.

Possibly related PRs

• Fix docker setup in Ubuntu #17: Modifies the debian-packages.yaml file by removing 'docker' and 'docker-compose', related to package management.
• Fix \n not being escaped properly #19: Changes the setup_passwordless_sudo function in the same script as the main PR, indicating a direct connection.

🐰 In the meadow where the code does flow,
A new tool named Git joins the show!
With sudoers safe and Docker less loud,
The scripts now sing, oh so proud!
Let's hop along, with joy in our hearts,
For each little change, a new journey starts! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 97a15d6 and 935d0c3.

Files selected for processing (4)

• home/.chezmoidata/debian-packages.yaml (1 hunks)
• home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl (1 hunks)
• home/.chezmoiscripts/run_once_after_02-asdf-install.sh.tmpl (1 hunks)
• home/.chezmoiscripts/run_once_after_03-docker-setup.sh.tmpl (2 hunks)

Files skipped from review due to trivial changes (1)

• home/.chezmoiscripts/run_once_after_03-docker-setup.sh.tmpl

Additional comments not posted (3)

home/.chezmoidata/debian-packages.yaml (1)

18-18: LGTM!

The addition of 'git' to the list of Debian packages is a useful enhancement to the development environment setup. Git is a widely used version control system and its inclusion will provide valuable functionality for managing source code.

This change aligns well with the PR objective of fixing issues with the Ubuntu setup by expanding the available toolset.

home/.chezmoiscripts/run_once_after_00-passwordless-sudo.sh.tmpl (1)

37-38: LGTM! This is a crucial security enhancement.

Changing the ownership of the /etc/sudoers and /etc/sudoers.d directories back to the root user after updating the sudoers file is an important security measure. It ensures that only the root user has the necessary permissions to modify the sudoers configuration, preventing potential unauthorized access or modifications by non-root users.

The recursive ownership change using the -R flag is also a good practice to ensure that all files and subdirectories within /etc/sudoers.d are properly secured.

This change enhances the overall security posture of the system by maintaining the integrity of the sudoers configuration.

home/.chezmoiscripts/run_once_after_02-asdf-install.sh.tmpl (1)

11-11: LGTM!

Sourcing the asdf.sh script immediately after cloning the asdf repository is a good addition. It ensures that the asdf environment is initialized right after installation, which is necessary for subsequent commands that rely on asdf being properly set up.

The change is correctly placed within the conditional block that checks if the asdf directory does not exist, and it does not introduce any apparent issues or side effects.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.