Revise golangci-lint configuration (TUM-Dev#1274)

* Linter fixup and demo

* Configure workflow separately

* Test to break the CI again

* Revert "Test to break the CI again"

This reverts commit 93fd948.

.gitattributes

@@ -0,0 +1 @@
+*.go text eol=lf

.github/workflows/golangci-lint.yml

@@ -21,3 +21,4 @@ jobs:
         uses: golangci/golangci-lint-action@v3
         with:
           version: latest
+          only-new-issues: true

.golangci.yml

@@ -1,3 +1,4 @@
+# For a description for each linter, see https://golangci-lint.run/usage/linters/.
 linters:
   enable:
     - gosimple
@@ -14,7 +15,6 @@ linters:
     - ineffassign
     - gofumpt
     - revive
-    - depguard
     - nakedret
     - unconvert
     - wastedassign
@@ -73,7 +73,8 @@ issues:
   max-issues-per-linter: 0
   max-same-issues: 0
   new: true
-  new-from-rev: HEAD
+  new-from-rev: dev
+  fix: false 
   exclude-rules:
     # Exclude some linters from running on tests files.
     - path: _test\.go

api/maintenance.go

@@ -2,12 +2,13 @@ package api
 
 import (
 	"fmt"
+	"net/http"
+	"strconv"
+
 	"github.com/TUM-Dev/gocast/dao"
 	"github.com/TUM-Dev/gocast/model"
 	"github.com/TUM-Dev/gocast/tools"
 	"github.com/gin-gonic/gin"
-	"net/http"
-	"strconv"
 )
 
 func configMaintenanceRouter(router *gin.Engine, daoWrapper dao.DaoWrapper) {

api/server-notifications.go

@@ -2,12 +2,13 @@ package api
 
 import (
 	"fmt"
+	"net/http"
+	"time"
+
 	"github.com/TUM-Dev/gocast/dao"
 	"github.com/TUM-Dev/gocast/model"
 	"github.com/TUM-Dev/gocast/tools"
 	"github.com/gin-gonic/gin"
-	"net/http"
-	"time"
 )
 
 func configServerNotificationsRoutes(engine *gin.Engine, daoWrapper dao.DaoWrapper) {

api/users.go

@@ -652,7 +652,6 @@ func (r usersRoutes) updateCustomSpeeds(c *gin.Context) {
 		})
 		return
 	}
-
 }
 
 func (r usersRoutes) updatePlaybackSpeeds(c *gin.Context) {

cmd/tumlive/tumlive.go

@@ -2,6 +2,14 @@ package main
 
 import (
 	"fmt"
+	"log/slog"
+	"net/http"
+	_ "net/http/pprof"
+	"os"
+	"os/signal"
+	"syscall"
+	"time"
+
 	"github.com/TUM-Dev/gocast/api"
 	"github.com/TUM-Dev/gocast/dao"
 	"github.com/TUM-Dev/gocast/model"
@@ -17,13 +25,6 @@ import (
 	"github.com/pkg/profile"
 	"gorm.io/driver/mysql"
 	"gorm.io/gorm"
-	"log/slog"
-	"net/http"
-	_ "net/http/pprof"
-	"os"
-	"os/signal"
-	"syscall"
-	"time"
 )
 
 var VersionTag = "development"
@@ -101,7 +102,7 @@ func main() {
 	}()
 
 	// log with time, fmt "23.09.2021 10:00:00"
-	//log.SetFormatter(&log.TextFormatter{TimestampFormat: "02.01.2006 15:04:05", FullTimestamp: true})
+	// log.SetFormatter(&log.TextFormatter{TimestampFormat: "02.01.2006 15:04:05", FullTimestamp: true})
 
 	web.VersionTag = VersionTag
 	osSignal = make(chan os.Signal, 1)

model/user.go

@@ -98,12 +98,9 @@ func (u *User) GetEnabledPlaybackSpeeds() (res []float32) {
 	if u == nil {
 		return []float32{1}
 	}
-	for _, setting := range u.GetPlaybackSpeeds().GetEnabled() {
-		res = append(res, setting)
-	}
-	for _, setting := range u.GetCustomSpeeds() {
-		res = append(res, setting)
-	}
+	// Possibly, this could be collapsed into a single line, but readibility suffers.
+	res = append(res, u.GetPlaybackSpeeds().GetEnabled()...)
+	res = append(res, u.GetCustomSpeeds()...)
 	sort.SliceStable(res, func(i, j int) bool {
 		return res[i] < res[j]
 	})