-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub Actions to work with Perl 5.16 and 5.18 #1508
Comments
It was worked around by manually listing the deps that need to be installed. It still won't do it automatically for some reason and only on these versions. (It's not just Sub::Util but all deps) |
Ah right, sorry I missed that @Grinnz. 🤦 Did some testing locally on 5.18 locally vs 5.20; in both cases, I started with $ perl --version | grep 'This is perl'
This is perl 5, version 18, subversion 4 (v5.18.4) built for x86_64-linux
$ cpanm --version | head -2
cpanm (App::cpanminus) version 1.7044 (/usr/local/bin/cpanm)
perl version 5.018004 (/usr/local/bin/perl)
$ cpanm --showdeps .
--> Working on .
Configuring /cwd ... OK
perl~5.016 vs: $ perl --version | grep 'This is perl'
This is perl 5, version 20, subversion 3 (v5.20.3) built for x86_64-linux
$ cpanm --version | head -2
cpanm (App::cpanminus) version 1.7044 (/usr/local/bin/cpanm)
perl version 5.020003 (/usr/local/bin/perl)
$ cpanm --showdeps .
--> Working on .
Configuring /cwd ... OK
perl~5.016
ExtUtils::MakeMaker
IO::Socket::IP~0.37
Sub::Util~1.41 In both cases, I get the same I'll be opening a PR shortly! 👍 |
I'm bothered by unexplained "for some reason" statements :) Something is seriously wrong in the toolchain setup if prereqs are not being detected. |
Totally agreed! As I noted in #1525 (comment), I did a little testing and found that EUMM version 6.68 is enough to fix it (up from 6.66 included in Perl 5.18). However, when adding Edit: Perl-Toolchain-Gang/ExtUtils-MakeMaker@35ad81b is the specific EUMM commit that fixes it, as far as I can tell. |
Note that configure requires are not relevant to MYMETA.json, they would be picked up from META.json before Makefile.PL is even run (so while it may not fix the CI it would be sufficient to fix users running into this case). |
the presence of |
In this case there is no META.json stored in the repository because tooling isn't in use that makes that easy and the only use of META.json in the repository is to support configure_requires for CI, which hasn't been needed yet. |
ah okay, thanks for the clarification. I thought CI was testing the result of 'make dist', which would have a META.json properly generated, not the bare repository. |
Only if it was using a new enough EUMM to run make dist 😐 |
For some reason our GitHub Actions do not install
Sub::Util
on Perl 5.16 and 5.18. So we had to disable those versions for now. But they are rather important and we'd like to get them back. So this needs to be investigated!The text was updated successfully, but these errors were encountered: