Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-upgrade "App::cpanminus" and "ExtUtils::MakeMaker" #1525

Merged
merged 1 commit into from
May 26, 2020

Conversation

tianon
Copy link
Contributor

@tianon tianon commented May 26, 2020

Summary

On Perl 5.18 and older, cpanm --installdeps was not picking up Sub::Util and IO::Socket::IP properly, and updating ExtUtils::MakeMaker fixes it. I included an update of App::cpanminus just for good measure.

Motivation

Fixes #1508 馃槃 馃巶

References

See #1508 for more details, especially #1508 (comment). 馃憤

This fixes issues with cpanm calculating dependencies properly on Perl 5.18 and older.
@karenetheridge
Copy link
Contributor

What is missing in older EUMM that these prereqs are missing? Doesn't that suggest that the CONFIGURE_REQUIRES entry for EUMM in Makefile.PL should be increased?

@tianon
Copy link
Contributor Author

tianon commented May 26, 2020

@karenetheridge a very good point, although definitely out of my depth -- hopefully this gives someone else enough to look into that 馃槆 鉂わ笍

Edit: in case it helps, Perl 5.18 has EUMM version 6.66 and 5.20 has EUMM version 6.98

@tianon
Copy link
Contributor Author

tianon commented May 26, 2020

Hmm, even just cpanm -n ExtUtils::MakeMaker@6.68 seems to be enough to fix it.

Looking through https://metacpan.org/diff/file?target=BINGOS/ExtUtils-MakeMaker-6.68/&source=BINGOS%2FExtUtils-MakeMaker-6.66#Changes, I think this might be relevant:

+6.67_04 Mon Jun 10 20:18:25 BST 2013
+    Bug fixes
+    * Address RT#85406, where specifying 'meta-spec' in
+      META_[ADD|MERGE] would remove all prereqs (bingos)

(The Mojolicious Makefile.PL includes 'meta-spec' => {version => 2}, in META_MERGE.)

@kraih kraih merged commit 03e7a0e into mojolicious:master May 26, 2020
@tianon tianon deleted the sub-util branch May 26, 2020 20:54
@karenetheridge
Copy link
Contributor

okay then, I would recommend adding CONFIGURE_REQUIRES => '6.68' to Makefile.PL, and then you should be able to remove all workarounds from docker and workflow configs.

thanks for tracking this down @tianon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix GitHub Actions to work with Perl 5.16 and 5.18
3 participants