Support async/await in Mojo::EventEmitter #1452
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using
Mojo::EventEmitter
withasync
/await
is very awkward, since the promises returned by async functions need to be referenced manually. This PR is a possible solution, but there is a performance cost. We useMojo::EventEmitter
very extensively in Mojolicious (and countless 3rd party modules), so it is hard to say if this could become a real problem.Here are before and after example apps.