Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for async functions to be used almost everywhere #1453

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Conversation

kraih
Copy link
Member

@kraih kraih commented Dec 27, 2019

This is an alternative to #1452. It has the advantage that async functions work pretty much everywhere automatically. It does have the downside that it deactivates the Future::AsyncAwait feature for detecting unhandled promises however. So it becomes much easier to miss exceptions in async functions.

@kraih
Copy link
Member Author

kraih commented Dec 27, 2019

If we decide to go with this solution, we should probably switch to a much more efficient internal alternative to finally (which requires the creation of yet another promise currently).

@kraih
Copy link
Member Author

kraih commented Dec 27, 2019

This solution is almost there, we just need a way to detect and throw unhandled rejections during DESTROY.

@kraih kraih merged commit b6d9220 into master Dec 27, 2019
@kraih kraih deleted the async_everywhere branch May 6, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant