Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-4185): Sync allowDiskUse default spec tests #3231

Merged
merged 2 commits into from
May 3, 2022
Merged

test(NODE-4185): Sync allowDiskUse default spec tests #3231

merged 2 commits into from
May 3, 2022

Conversation

kampofo
Copy link
Contributor

@kampofo kampofo commented May 3, 2022 •
edited
Loading

Description

NODE-4185

What is changing?

This PR syncs the spec tests from DRIVERS-2265 as required from NODE-4185

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests

@baileympearson baileympearson mentioned this pull request May 3, 2022
Merged
5 tasks
baileympearson
baileympearson requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fill out the PR description?

test/spec/crud/unified/aggregate-allowediskuse.json Outdated Show resolved Hide resolved
@baileympearson baileympearson changed the title chore(NODE-4185): Make allowDiskUse opt-out rather than opt-in in 6.0 test(NODE-4185): Make allowDiskUse opt-out rather than opt-in in 6.0 May 3, 2022
@baileympearson baileympearson changed the title test(NODE-4185): Make allowDiskUse opt-out rather than opt-in in 6.0 test(NODE-4185): Sync allowDiskUse default spec tests May 3, 2022
@baileympearson baileympearson merged commit c54df3f into main May 3, 2022
@baileympearson baileympearson deleted the NODE-4185 branch May 3, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kampofo @baileympearson