Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2265: Tests for aggregate allowDiskUse option #1178

Merged
merged 1 commit into from
Apr 12, 2022
Merged

DRIVERS-2265: Tests for aggregate allowDiskUse option #1178

merged 1 commit into from
Apr 12, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Apr 12, 2022 •
edited
Loading

@jmikola jmikola requested a review from a team as a code owner April 12, 2022 18:17
@jmikola jmikola requested review from benjirewis and removed request for a team April 12, 2022 18:17
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Apr 12, 2022
@jmikola
PHPLIB-841: Tests for aggregate allowDiskUse option
686dcbe 
Synced with mongodb/specifications#1178
@jmikola jmikola mentioned this pull request Apr 12, 2022
Merged
jyemin
jyemin approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened to see this and was curious if Java driver already passes the new tests: it does.

One nit, but LGTM either way.

source/crud/tests/unified/aggregate-allowdiskuse.json Outdated Show resolved Hide resolved
benjirewis
benjirewis approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes in the Go driver; LGTM mod @jyemin's typo callout.

@jmikola jmikola merged commit 53b7f16 into mongodb:master Apr 12, 2022
@jmikola jmikola deleted the drivers-2265 branch April 12, 2022 19:37
@kampofo kampofo mentioned this pull request May 3, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikola @jyemin @benjirewis