Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal APIs #1394

Merged
merged 17 commits into from
Feb 2, 2021
Merged

Add Metal APIs #1394

merged 17 commits into from
Feb 2, 2021

Conversation

mattleibow
Copy link
Contributor

Description of Change

First look at adding the APIs to work with Metal.

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Copy link
Contributor Author

This is just hacky right now, but I think I m doing it wrong as it crashes when creating the surface. I think I am not working with the objc objects correctly.

@mattleibow mattleibow marked this pull request as draft July 10, 2020 22:53
@mattleibow
Copy link
Contributor Author

Fixed that crash... was passing a struct off as a field in that struct, darned void* accepting everything.

@mattleibow mattleibow marked this pull request as ready for review July 22, 2020 00:30
@nor0x
Copy link

nor0x commented Dec 7, 2020

hi @mattleibow 👋
could you update me on the status of the Metal APIs? My current project could really benefit of Metal support and i would be happy to help with this PR

Thanks!

@mattleibow
Copy link
Contributor Author

@nor0x I was waiting to see what would happen with the API as the new versions. So far it looks safe. Just waiting on another test PR to build: #1598

If that is mostly green then I might just merge.

@AnarchyMob
Copy link

Hello, do you know how things are with the Direct3D backend in 88 milestone?

@mattleibow
Copy link
Contributor Author

@AnarchyMob I have a PR for m88 at #1596

I have not tested the D3D yet as that is just an update of the current set of APIs. You can also ask all about the support level and feature set on the skia forums: https://groups.google.com/g/skia-discuss

I think we are still in an early stage of D3D, but I need to confirm. However, I think things are mostly working. A bit unsure here...

@mattleibow mattleibow merged commit 2a87a0d into master Feb 2, 2021
@mattleibow mattleibow deleted the dev/metal branch February 2, 2021 11:59
mattleibow added a commit that referenced this pull request Feb 2, 2021
mattleibow added a commit that referenced this pull request Feb 2, 2021
mattleibow added a commit that referenced this pull request Feb 2, 2021
* Remove the externals/harfbuzz submodule (#1599)
* Add Metal APIs for macOS and iOS (#1394)
* docs: Add unoplatform references (#1602)
* Add a symlink for a "missing" file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Metal APIs
3 participants