Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the externals/harfbuzz submodule #1599

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Remove the externals/harfbuzz submodule #1599

merged 1 commit into from
Feb 1, 2021

Conversation

mattleibow
Copy link
Contributor

Description of Change

Use the gn targets in skia to do all the work as not only is that less work, but we have less submodules to worry about.

Bugs Fixed

None.

API Changes

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Remove the externals/harfbuzz submodule
e472aed 
Use the gn targets in skia to do all the work
@mattleibow mattleibow added this to In progress in v2.80.3 via automation Feb 1, 2021
@mattleibow mattleibow merged commit 7d087c9 into master Feb 1, 2021
v2.80.3 automation moved this from In progress to Done Feb 1, 2021
@mattleibow mattleibow deleted the dev/remove-harfbuzz-submodule branch February 1, 2021 21:13
mattleibow added a commit that referenced this pull request Feb 2, 2021
@mattleibow
Merge Metal APIs from main branch (#1598)
0cd7fe5 
* Remove the externals/harfbuzz submodule (#1599)
* Add Metal APIs for macOS and iOS (#1394)
* docs: Add unoplatform references (#1602)
* Add a symlink for a "missing" file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/Build
Projects
No open projects
v2.80.3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattleibow