Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eth_call for past blocks with old runtimes #2780

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

librelois
Copy link
Collaborator

@librelois librelois commented Apr 24, 2024

What does it do?

Frontier PR #1257 introduce a regression that make the client not compatible with old runtimes.
Old runtimes doesn't check properly non transactional evm calls, old runtimes rely on the fact that max_fee_per_gas is None to consider the evm call non transactional.
It introduced a bug in Moonbeam where eth_call against past blocks produce the BalanceLow error.
Because we can't change old runtimes, the client should not set max_fee_per_gas as Some(zero), otherwize old runtimes will assume that the evm call is transactional.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes not-breaking Does not need to be mentioned in breaking changes labels Apr 24, 2024
Copy link
Contributor

github-actions bot commented Apr 24, 2024

Coverage Report

@@                      Coverage Diff                       @@
##           master   elois-eth-call-old-runtimes     +/-   ##
==============================================================
  Coverage   73.06%                        73.06%   0.00%     
  Files         228                           228             
  Lines       69944                         69944             
==============================================================
  Hits        51103                         51103             
  Misses      18841                         18841             
Files Changed Coverage

Coverage generated Thu Apr 25 10:12:44 UTC 2024

@librelois librelois added the D3-trivial PR contains trivial changes in a runtime directory that do not require an audit label Apr 25, 2024
@noandrea noandrea merged commit 795b18f into master Apr 25, 2024
29 of 31 checks passed
@noandrea noandrea deleted the elois-eth-call-old-runtimes branch April 25, 2024 12:33
noandrea pushed a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants