support eth_call for past blocks with old runtimes #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch LGTM, please fix the CI. |
boundless-forest
approved these changes
Apr 25, 2024
boundless-forest
added a commit
that referenced
this pull request
Apr 30, 2024
This reverts commit e7fccf9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #1257 introduced a regression that make the client not compatible with old runtimes.
Old runtimes doesn't check properly non transactional evm calls, old runtimes rely on the fact that max_fee_per_gas is None to consider the evm call non transactional.
It introduced a bug in Moonbeam where eth_call against past blocks produce the
BalanceLowerror.Because we can't change old runtimes, the client should not set
max_fee_per_gasasSome(zero), otherwize old runtimes will assume that the evm call is transactional.