Dedicated AccountId20 type

[JoshOrndorff]

What does it do?

This PR adds a dedicated type AccountId20 rather than using the general purpose hash type H160 as previously.

What important points reviewers should know?

In general, this strengthens the type system's ability to prevent us from putting inappropriate data where an account id is expected. But speaking practically, we're hoping this will allow tools that depend on type metadata (like PolkadotJs) to better infer that account-related UI components should be used.

Is there something left for follow-up PRs?

Much of this can be upstreamed to Frontier and generalized. For now this is ready for PoC work on the Polkadot JS tools.

What value does it bring to the blockchain users?

Hopefully, nicer formatting of Account Ids in UI components and easier ability to choose accounts from a list (rather than pasting bytes).

[joelamouche]

@JoshOrndorff Please use AccountId20 type instead

[joelamouche]

Or EthereumAddress

[JoshOrndorff]

When we move this upstream into frontier, @tgmichel recommended we make a fp-ethereum crate for the AccountId20 type.

[JoshOrndorff]

@joelamouche This is the type. The moonbase runtime's metadata contains this. So I guess the path is account::AccountId20 which makes sense from a Rust perspective.

          {
            id: 0
            type: {
              path: [
                account
                AccountId20
              ]
              params: []
              def: {
                Composite: {
                  fields: [
                    {
                      name: null
                      type: 1
                      typeName: [u8; 20]
                      docs: []
                    }
                  ]
                }
              }
              docs: []
            }
          }

[JoshOrndorff]

Thanks a lot for your help @girazoki 🙏

This is ready for your review and experimentation @joelamouche (or @crystalin because you mentioned that having the poor account formatting is making your testing procedures take longer).

[JoshOrndorff]

@joelamouche I believe I've done as you asked for the ts dependencies. Can you confirm? Feel free to revert those commits or push new commits if this is not right.

[joelamouche]

WIP on a PR that will fix the tests

[joelamouche]

@JoshOrndorff pls look at the failing rust tests:

error[E0308]: mismatched types
    --> runtime/moonbeam/tests/integration_test.rs:1209:13
     |
1209 |                 source: AccountId::from(ALICE),
     |                         ^^^^^^^^^^^^^^^^^^^^^^ expected struct `H160`, found struct `account::AccountId20`

error[E0308]: mismatched types
    --> runtime/moonbeam/tests/integration_test.rs:1210:13
     |
1210 |                 target: AccountId::from(BOB),
     |                         ^^^^^^^^^^^^^^^^^^^^ expected struct `H160`, found struct `account::AccountId20`

error[E0308]: mismatched types
    --> runtime/moonbeam/tests/integration_test.rs:1237:13
     |
1237 |                 source: AccountId::from(ALICE),
     |                         ^^^^^^^^^^^^^^^^^^^^^^ expected struct `H160`, found struct `account::AccountId20`

   Compiling moonbeam-relay-encoder v0.1.0 (/Users/antoineestienne/GitHubRepo/double_repos/moonbeam/runtime/relay-encoder)
error[E0308]: mismatched types
    --> runtime/moonbeam/tests/integration_test.rs:1238:13
     |
1238 |                 target: AccountId::from(BOB),
     |                         ^^^^^^^^^^^^^^^^^^^^ expected struct `H160`, found struct `account::AccountId20`

[joelamouche]

error: duplicate lang item in crate `sp_io` (which `frame_support` depends on): `panic_impl`.
    |
    = note: the lang item is first defined in crate `sp_io` (which `frame_support` depends on)
    = note: first definition in `sp_io` loaded from /home/gh-actions/runner/_work/moonbeam/moonbeam/target/release/wbuild/moonbase-runtime/target/wasm32-unknown-unknown/release/deps/libsp_io-41280f87bae211df.rmeta
    = note: second definition in `sp_io` loaded from /home/gh-actions/runner/_work/moonbeam/moonbeam/target/release/wbuild/moonbase-runtime/target/wasm32-unknown-unknown/release/deps/libsp_io-e8003f60efd7156c.rmeta

  error: duplicate lang item in crate `sp_io` (which `frame_support` depends on): `oom`.
    |
    = note: the lang item is first defined in crate `sp_io` (which `frame_support` depends on)
    = note: first definition in `sp_io` loaded from /home/gh-actions/runner/_work/moonbeam/moonbeam/target/release/wbuild/moonbase-runtime/target/wasm32-unknown-unknown/release/deps/libsp_io-41280f87bae211df.rmeta
    = note: second definition in `sp_io` loaded from /home/gh-actions/runner/_work/moonbeam/moonbeam/target/release/wbuild/moonbase-runtime/target/wasm32-unknown-unknown/release/deps/libsp_io-e8003f60efd7156c.rmeta
    ```

[joelamouche]

type errors due to polkadot-js/api#4213 for latest version and this old version is not up to date

[joelamouche]

Problem with types is now tracked here: polkadot-js/api#4241