Fix test for new AccountId20 type branch #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoshOrndorff pls review |
joelamouche
added
A0-pleasereview
JoshOrndorff
approved these changes
Nov 9, 2021
jacogr
reviewed
Nov 9, 2021
| @@ -92,7 +92,7 @@ describeDevMoonbeam("Staking - Join Candidates", (context) => { | |||
| "new candidate should have been added" | |||
| ); | |||
| expect((candidatesAfter.toJSON() as { owner: string; amount: string }[])[1].owner).to.equal( | |||
| ETHAN.toLowerCase(), | |||
| ETHAN, | |||
There was a problem hiding this comment.
it did work locally
JoshOrndorff
added a commit
that referenced
this pull request
Nov 23, 2021
* initial draft installed in moonbase * fix cli-opt * comment about better Display impl * `Copy`, `FromStr`, and make it build * rename to AccountId20 * Same FromStr error as AccountId32 * more comment ideas * Do Moonriver and Moonbeam runtimes * simplify asset_id_to_account * start on moonbase tests * moonbase tests pass * river and beam * proper blanket impl * Be generic over the destination type too 🤷 I'll let @nanocryk tell me how generic it is really appropriate to be here. * fix account tests * Fix tests * update @PolkaDot dependencies in types bundle * update @PolkaDot dependencies in tests * update @PolkaDot dependencies in tools * unused imports * update deps and fix tests (#975) * Joshy moonbeam account : remove toLowercase (#977) * remove tolowercase * wip fixing tests * fix tests * finish fixing tests * remove todos * remove more todos * update package-lock * Fix recently-merged integration tests * fix crossed dependencies in runtime-common * fix package-lock * downgrade polkadot/types because its broken * update deps * update deps * Joshy moonbeam account downgrade attempt (#1019) * tried downgrading * update types Co-authored-by: gorka <gorka.irazoki@gmail.com> Co-authored-by: Antoine Estienne <antoine@purestake.com> Co-authored-by: estienne.antoine@gmail.com <estienne.antoine@gmail.com>
notlesh
pushed a commit
that referenced
this pull request
Nov 24, 2021
* initial draft installed in moonbase * fix cli-opt * comment about better Display impl * `Copy`, `FromStr`, and make it build * rename to AccountId20 * Same FromStr error as AccountId32 * more comment ideas * Do Moonriver and Moonbeam runtimes * simplify asset_id_to_account * start on moonbase tests * moonbase tests pass * river and beam * proper blanket impl * Be generic over the destination type too 🤷 I'll let @nanocryk tell me how generic it is really appropriate to be here. * fix account tests * Fix tests * update @PolkaDot dependencies in types bundle * update @PolkaDot dependencies in tests * update @PolkaDot dependencies in tools * unused imports * update deps and fix tests (#975) * Joshy moonbeam account : remove toLowercase (#977) * remove tolowercase * wip fixing tests * fix tests * finish fixing tests * remove todos * remove more todos * update package-lock * Fix recently-merged integration tests * fix crossed dependencies in runtime-common * fix package-lock * downgrade polkadot/types because its broken * update deps * update deps * Joshy moonbeam account downgrade attempt (#1019) * tried downgrading * update types Co-authored-by: gorka <gorka.irazoki@gmail.com> Co-authored-by: Antoine Estienne <antoine@purestake.com> Co-authored-by: estienne.antoine@gmail.com <estienne.antoine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?